On 2/14/20 5:26 PM, Pavel Mores wrote:
v2 is mostly just integrating requests from Michal's review. The initial two
commits introduce new utility functions to be used in the following two
commits. The final two commits have no substantial changes since v1.
The only exception are long lines caused by error messages which stay unbroken
in v2 as per libvirt's contributor's guidelines (as was also pointed out during
review).
Pavel Mores (6):
qemu: test if bandwidth has 'floor' factored out to separate function
qemu: add function to test if network supports setting 'floor'
qemu: fail on attempt to set 'floor' if interface type is not
'network'
qemu: check if 'floor' is supported for given interface and network
qemu: call networkPlugBandwidth() for all types of network
docs: QoS parameter 'floor' is supported for 'open' networks too
docs/formatnetwork.html.in | 2 +-
src/conf/netdev_bandwidth_conf.h | 27 +++++++++++++++++++++++++++
src/network/bridge_driver.c | 27 +++++++++++++++++++--------
src/qemu/qemu_driver.c | 18 +++++++++++++++---
4 files changed, 62 insertions(+), 12 deletions(-)
I'm fixing all the small issues I've raised and pushing.
Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
Michal
