Re: [libvirt PATCH v2 6/8] tests: Add test case for the armvtimer timer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2020-02-13 at 14:30 +0100, Ján Tomko wrote:
> On Fri, Feb 07, 2020 at 03:27:06PM +0100, Andrea Bolognani wrote:
> > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> > ---
> > .../clock-timer-armvtimer.aarch64-latest.args | 32 +++++++++++++++++++
> > .../clock-timer-armvtimer.xml                 | 27 ++++++++++++++++
> > tests/qemuxml2argvtest.c                      |  2 ++
> > .../clock-timer-armvtimer.aarch64-latest.xml  |  1 +
> > tests/qemuxml2xmltest.c                       |  1 +
> > 5 files changed, 63 insertions(+)
> > create mode 100644 tests/qemuxml2argvdata/clock-timer-armvtimer.aarch64-latest.args
> > create mode 100644 tests/qemuxml2argvdata/clock-timer-armvtimer.xml
> > create mode 120000 tests/qemuxml2xmloutdata/clock-timer-armvtimer.aarch64-latest.xml
> 
> Personally, having the XML test squashed with the XML parser/formatter
> and the ->argv conversion with the QEMU command line formatter feels
> nicer.

I tend to agree, and that's how I had it initially, but in this
particular case it ended up being more confusing IMHO.

I can split it again if you want me to. Your call entirely :)

-- 
Andrea Bolognani / Red Hat / Virtualization





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux