Re: [libvirt PATCH] tests: fix deadlock in eventtest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 06, 2020 at 01:22:28PM +0100, Pavel Hrdina wrote:
> There is a race deadlock in eventtest after the recent rewrite to drop
> GNULIB from libvirt code base.
> 
> The issue happens when the callbacks testPipeReader() or testTimer()
> are called before waitEvents() starts waiting on `eventThreadCond`.
> It will never happen because the callbacks are already done and there
> is nothing that will signal the condition again.
> 
> Reported-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> ---
>  tests/eventtest.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux