On Wed, Feb 05, 2020 at 05:18:03PM +0000, Daniel P. Berrangé wrote: > On Thu, Jan 30, 2020 at 03:51:05PM +0100, Pavel Hrdina wrote: > > On Tue, Jan 28, 2020 at 01:11:15PM +0000, Daniel P. Berrangé wrote: > > > To eliminate the dependancy on GNULIB's poll impl, we need > > > to change the RPC client code to use GMainLoop. We don't > > > really want to use GIOChannel, but it provides the most > > > convenient way to do socket event watches with Windows > > > portability. The other alternative would be to use GSocket > > > but that is a much more complex change affecting libvirt > > > more broadly. > > > > > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > > > --- > > > src/rpc/virnetclient.c | 215 ++++++++++++++++++++++------------------- > > > 1 file changed, 113 insertions(+), 102 deletions(-) > > > > > > diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c > > > index 031a99711f..9069c57113 100644 > > > --- a/src/rpc/virnetclient.c > > > +++ b/src/rpc/virnetclient.c > > > @@ -800,11 +791,7 @@ static void virNetClientCloseInternal(virNetClientPtr client, > > > * queue and close the client because we set client->wantClose. > > > */ > > > > This comment should be probably updated to not reference threads. > > I'm not sure what you mean here, as the comment looks still > accurate to me. After reading it again you are correct, there is nothing wrong with it. Well feel free to disregard it. Pavel
Attachment:
signature.asc
Description: PGP signature
