Re: [libvirt PATCH] conf: use correct free function for virDomainDeviceDef

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 05, 2020 at 01:26:11 +0100, Ján Tomko wrote:
> Simple g_autofree is not enough if we put allocated
> data into the device structure.
> 
> Define the AUTOPTR_CLEANUP function and use it here.
> 
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> Reported-by: Xu Yandong <xuyandong2@xxxxxxxxxx>

Ah, so this bug was actually introduced when adding the post parse and
validation callbacks, because otherwise it doesn't set anything in the
struct.

> ---
>  src/conf/domain_conf.c | 2 +-
>  src/conf/domain_conf.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux