Re: [libvirt PATCH 0/4] qemu: tpm: use g_auto

[Ján Tomko <jtomko@xxxxxxxxxx>]

On Mon, Feb 03, 2020 at 09:12:57AM +0100, Peter Krempa wrote:
> On Sun, Feb 02, 2020 at 21:01:43 +0100, Ján Tomko wrote:
> > Ján Tomko (4):
> >   qemu: tpm: remove unused pidfile variable
> >   qemu: tpm: use g_autofree
> >   qemu: tpm: use g_autoptr where applicable
>
> I don't understand why we split g_autofree and g_autoptr. Specifically
> as g_autoptr patches usually combine changes to distinct types.

Usually the g_autoptr changes are fewer than the mechanical g_autofree
changes, which made it worth it for large files.

That might not be the case here, but it's easier to squash
patches together than to separate them :)

Jano

> >   qemu: tpm: remove unused labels
>
> Nevertheless:
>
> Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature