Re: [libvirt PATCH v2 37/56] tests: refactor event test to not run lock step

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 28, 2020 at 01:11:18PM +0000, Daniel P. Berrangé wrote:
> The current event loop test suite has two threads running
> in lockstep. This was just about viable when we have full
> control over the internal details of the event loop impl.
> When we're using the GLib event loop though there are
> things going on that we don't know about, such as use of
> eventfd() file descriptors. This will break the assumptions
> in the test suite, causing non-deterministic failures.
> 
> This change switches the event loop thread to run fully
> asynchronously from the test suite cases. This is slightly
> weaker validation, but the only way we can get a reliable
> test suite.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  tests/eventtest.c | 151 +++++++++++++++++++---------------------------
>  1 file changed, 63 insertions(+), 88 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux