This series was originally posted by Nikolay here: https://www.redhat.com/archives/libvir-list/2020-January/msg00283.html I've delayed review too much. Sorry for that. To make it up to you, I've fixed some patches and resending the series. Basically, I want to know whether you agree with my adjustments. I will add Dan's Reviewed-by when merging. Nikolay Shirokovskiy (7): qemu: Move qemuDiskConfigBlkdeviotuneHas* to conf conf: expand iotune params if only group name is given qemu: propagate iotune settings to all disks in the group qemu: check iotune params same for all disk in group qemu: fix using defaults when setting persistent iotune params qemu: get defaults from iotune group we move disk into qemu: when leaving iotune group update xml properly src/conf/domain_conf.c | 108 +++++++++++++++++++++++++++++++++++++++ src/conf/domain_conf.h | 22 ++++++++ src/libvirt_private.syms | 6 +++ src/qemu/qemu_command.c | 91 ++++++++++++++------------------- src/qemu/qemu_command.h | 3 ++ src/qemu/qemu_driver.c | 94 ++++++++++++++++++++++++++++++++-- src/qemu/qemu_hotplug.c | 2 +- tests/qemublocktest.c | 8 ++- 8 files changed, 275 insertions(+), 59 deletions(-) -- 2.24.1
