Re: [libvirt PATCH 09/10] Add a space before ending a comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 28, 2020 at 13:22:26 +0100, Ján Tomko wrote:
> On Tue, Jan 28, 2020 at 12:13:14PM +0100, Peter Krempa wrote:
> > On Tue, Jan 28, 2020 at 11:31:25 +0100, Ján Tomko wrote:
> > 
> > It also adds space after the start of the comment in many cases.
> > 
> > > Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> > > ---
> > >  src/conf/capabilities.h           |  2 +-
> > >  src/conf/cpu_conf.c               |  2 +-
> > >  src/conf/domain_conf.c            |  8 ++--
> > >  src/conf/storage_conf.h           |  2 +-
> > >  src/esx/esx_network_driver.c      |  2 +-
> > >  src/libxl/libxl_conf.c            |  2 +-
> > >  src/libxl/libxl_conf.h            |  2 +-
> > >  src/libxl/xen_xm.c                |  2 +-
> > >  src/locking/lock_daemon.c         |  2 +-
> > >  src/logging/log_daemon.c          |  2 +-
> > >  src/lxc/lxc_conf.h                |  2 +-
> > >  src/lxc/lxc_controller.c          |  4 +-
> > >  src/lxc/lxc_process.c             |  2 +-
> > >  src/network/bridge_driver.c       |  2 +-
> > >  src/network/bridge_driver_linux.c |  2 +-
> > >  src/openvz/openvz_conf.c          |  4 +-
> > >  src/openvz/openvz_driver.c        |  4 +-
> > >  src/qemu/qemu_capabilities.h      |  4 +-
> > >  src/qemu/qemu_conf.h              |  2 +-
> > >  src/qemu/qemu_domain.c            |  4 +-
> > >  src/qemu/qemu_domain_address.c    |  2 +-
> > >  src/qemu/qemu_driver.c            |  2 +-
> > >  src/qemu/qemu_hotplug.c           |  2 +-
> > >  src/qemu/qemu_interface.c         |  2 +-
> > >  src/remote/remote_daemon.c        |  2 +-
> > >  src/rpc/virnetclient.c            |  2 +-
> > >  src/rpc/virnetsshsession.c        |  4 +-
> > >  src/security/security_apparmor.c  |  2 +-
> > >  src/storage/storage_util.c        |  2 +-
> > >  src/test/test_driver.c            |  4 +-
> > >  src/util/virarch.h                |  2 +-
> > >  src/util/vircommand.c             |  2 +-
> > >  src/util/virnetdevbandwidth.c     |  2 +-
> > >  src/util/virnetdevvportprofile.c  |  2 +-
> > >  src/util/virnetlink.c             |  4 +-
> > >  src/util/virperf.h                |  6 +--
> > >  src/util/virresctrl.c             |  2 +-
> > >  src/vbox/vbox_common.c            | 65 ++++++++++++++++---------------
> > >  src/vbox/vbox_snapshot_conf.c     | 28 ++++++-------
> > >  src/vbox/vbox_tmpl.c              |  2 +-
> > >  src/vz/vz_driver.c                |  2 +-
> > >  tests/objecteventtest.c           |  2 +-
> > >  tests/qemuagenttest.c             |  2 +-
> > >  tests/vboxsnapshotxmltest.c       |  2 +-
> > >  tests/vshtabletest.c              |  2 +-
> > >  tools/virsh-domain-monitor.c      |  2 +-
> > >  tools/virsh-domain.c              |  8 ++--
> > >  tools/virsh-pool.c                |  2 +-
> > >  48 files changed, 109 insertions(+), 108 deletions(-)
> > 
> > I'm not really convinced that the churn outweighs the benefits of the
> > change especially since it was apparently done programatically yet this
> > patch/series is not adding a syntax-check rule.
> > 
> 
> Parts of it were done by 'git grep', but for the rest I trained a neural
> network [0], which I do not feel comfortable putting into syntax check.

Hmm, ok.

Just fix the summary.

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux