Re: [PATCH 6/7] qemu: get defaults from iotune group we move disk into

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 08, 2020 at 09:49:30AM +0300, Nikolay Shirokovskiy wrote:
> For example if disk is not in the group and we want to move it
> there then it makes sense to specify only the group name in API call.
> Currently the destination group iotune settings will be overwritten
> with the disk settings which I would say is not what one would expect.
> Thus let's get defaults from the group we are moving to.
> 
> And if we are moving the brand new group then is makes sense to
> copy the current disk iotune settings to the group.
> 
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx>
> ---
>  src/qemu/qemu_driver.c | 33 +++++++++++++++++++++++++++++++--
>  1 file changed, 31 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux