Re: [RFC PATCH 11/16] tests: qemublock: Add few more test cases for checkpoint deletion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/9/20 12:21 PM, Peter Krempa wrote:
Add all intermediate steps and deletion of the current checkpoint on a
flat (single-image) disk image.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
  tests/qemublocktest.c                         |  4 +++
  .../checkpointdelete/basic-current-out.json   | 29 +++++++++++++++++++
  .../basic-intermediate1-out.json              | 22 ++++++++++++++
  .../basic-intermediate2-out.json              | 22 ++++++++++++++
  .../basic-intermediate3-out.json              | 22 ++++++++++++++
  5 files changed, 99 insertions(+)
  create mode 100644 tests/qemublocktestdata/checkpointdelete/basic-current-out.json
  create mode 100644 tests/qemublocktestdata/checkpointdelete/basic-intermediate1-out.json
  create mode 100644 tests/qemublocktestdata/checkpointdelete/basic-intermediate2-out.json
  create mode 100644 tests/qemublocktestdata/checkpointdelete/basic-intermediate3-out.json


+++ b/tests/qemublocktestdata/checkpointdelete/basic-current-out.json
@@ -0,0 +1,29 @@
+[
+  {
+    "type": "block-dirty-bitmap-enable",
+    "data": {
+      "node": "libvirt-1-format",
+      "name": "d"
+    }
+  },
+  {
+    "type": "block-dirty-bitmap-merge",
+    "data": {
+      "node": "libvirt-1-format",
+      "target": "d",
+      "bitmaps": [
+        {
+          "node": "libvirt-1-format",
+          "name": "current"
+        }
+      ]
+    }
+  },
+  {
+    "type": "block-dirty-bitmap-remove",
+    "data": {
+      "node": "libvirt-1-format",
+      "name": "current"
+    }
+  }
+]

Creates a rather large transaction (3 items, of which one itself takes an array of bitmaps), but that's par for the course. The test looks good.

Reviewed-by: Eric Blake <eblake@xxxxxxxxxx>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux