Re: [libvirt PATCH v2 2/6] conf: parse/format <teaming> subelement of <interface>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 24, 2020 at 10:39:17AM -0500, Laine Stump wrote:
> The subelement <teaming> of <interface> devices is used to configure a
> simple teaming association between two interfaces in a domain. Example:
> 
>   <interface type='bridge'>
>     <source bridge='br0'/>
>     <model type='virtio'/>
>     <mac address='00:11:22:33:44:55'/>
>     <alias name='ua-backup0'/>
>     <teaming type='persistent'/>
>   </interface>
>   <interface type='hostdev'>
>     <source>
>       <address type='pci' bus='0x02' slot='0x10' function='0x4'/>
>     </source>
>     <mac address='00:11:22:33:44:55'/>
>     <teaming type='transient' persistent='ua-backup0'/>
>   </interface>
> 
> The interface with <teaming type='persistent'/> is assumed to always
> be present, while the interface with type='transient' may be be
> unplugged and later re-plugged; the persistent='blah' attribute (and
> in the one currently available implementation, also the matching MAC
> addresses) is what associates the two devices with each other. It is
> up to the hypervisor and the guest network drivers to determine what
> to do with this information.
> 
> Signed-off-by: Laine Stump <laine@xxxxxxxxxx>
> ---
> 
>  docs/schemas/domaincommon.rng                 | 19 ++++++
>  src/conf/domain_conf.c                        | 45 +++++++++++++
>  src/conf/domain_conf.h                        | 14 ++++
>  .../net-virtio-teaming-network.xml            | 37 +++++++++++
>  tests/qemuxml2argvdata/net-virtio-teaming.xml | 50 ++++++++++++++
>  .../net-virtio-teaming-network.xml            | 51 ++++++++++++++
>  .../qemuxml2xmloutdata/net-virtio-teaming.xml | 66 +++++++++++++++++++
>  tests/qemuxml2xmltest.c                       |  6 ++
>  8 files changed, 288 insertions(+)
>  create mode 100644 tests/qemuxml2argvdata/net-virtio-teaming-network.xml
>  create mode 100644 tests/qemuxml2argvdata/net-virtio-teaming.xml
>  create mode 100644 tests/qemuxml2xmloutdata/net-virtio-teaming-network.xml
>  create mode 100644 tests/qemuxml2xmloutdata/net-virtio-teaming.xml

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux