Re: [RFC PATCH 06/16] qemu: checkpoint: tolerate missing disks on checkpoint deletion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/9/20 12:21 PM, Peter Krempa wrote:
If a disk is unplugged and then the user tries to delete a checkpoint
the code would try to use NULL node name as it was not checked.

Fix this by fetching the whole disk definition object and verifying it
was found.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
  src/qemu/qemu_checkpoint.c | 23 +++++++++++++++++------
  1 file changed, 17 insertions(+), 6 deletions(-)


Reviewed-by: Eric Blake <eblake@xxxxxxxxxx>

But it also makes me wonder if the act of hot-unplug should update the definition of existing checkpoints. (Doesn't stop this patch from being useful as-is, but may point to further design work and future patches)

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux