On Fri, Jan 24, 2020 at 03:01:51PM +0000, Daniel P. Berrangé wrote: > On Fri, Jan 24, 2020 at 02:51:39PM +0000, Richard W.M. Jones wrote: > > On Fri, Jan 24, 2020 at 02:35:01PM +0000, Daniel P. Berrangé wrote: > > > On Sun, Jan 19, 2020 at 01:04:07PM +0000, Richard W.M. Jones wrote: > > > > Basically OCaml 4.10 is much more strict about the difference between > > > > string (immutable) and bytes (mutable). > > > > > > For all patches > > > > > > Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > > > > > > I presume this will fix the rawhide CI failure we have with ocaml > > > now. > > > > Well the previous code didn't compile with OCaml 4.10 at all, so I > > guess so. However I wasn't previously aware we even had CI for this. > > Do you have a link? > > Rawhide was succeeding until most recent build: > > https://ci.centos.org/view/libvirt/job/libvirt-ocaml-build/ Yes, that's all caused by the OCaml 4.10 update. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
