Re: [PATCH 1/2] qemu: Converting DHCP and ARP functions to domain conf

[Michal Privoznik <mprivozn@xxxxxxxxxx>]

On 1/21/20 4:37 AM, Julio Faracco wrote:
> QEMU driver has two functions: qemuGetDHCPInterfaces() and
> qemuARPGetInterfaces() that are being used inside only one single
> function. They can be turned into generic functions that other drivers
> can use. This commit move both from QEMU driver tree to domain conf
> tree.
>
> Signed-off-by: Julio Faracco <jcfaracco@xxxxxxxxx>
> ---
>   src/conf/domain_conf.c   | 134 ++++++++++++++++++++++++++++++++++++++
>   src/conf/domain_conf.h   |   2 +
>   src/libvirt_private.syms |   2 +
>   src/qemu/qemu_driver.c   | 137 +--------------------------------------
>   4 files changed, 140 insertions(+), 135 deletions(-)


> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index b63feb4054..3cfeebb220 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -524,6 +524,8 @@ virDomainNetTypeFromString;
>   virDomainNetTypeSharesHostView;
>   virDomainNetTypeToString;
>   virDomainNetUpdate;
> +virDomainNetDHCPInterfaces;
> +virDomainNetARPInterfaces;

Not ordered properly. 'make syntax-check' would have caught this.

>   virDomainNostateReasonTypeFromString;
>   virDomainNostateReasonTypeToString;
>   virDomainObjAssignDef;

Michal