On Fri, Jan 17, 2020 at 6:32 PM Andrea Bolognani <abologna@xxxxxxxxxx> wrote:
On Thu, 2020-01-16 at 09:28 +0100, Christian Ehrhardt wrote:
> If virHostdevManagerGetDefault in qemuhotplugtest fails it works
> for quite a while to later segfault when accessing
> mgr->activePCIHostdevs.
>
> Report the error details and break on a failed init to see the
> real issue right away.
>
> Reviewed-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx>
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@xxxxxxxxxxxxx>
> ---
> tests/qemuhotplugtest.c | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
Thanks for the reviews Daniel and Andrea, I have pushed this (just this - not the 2/2 which is still up for discussion) to master now.
--
Andrea Bolognani / Red Hat / Virtualization
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
Staff Engineer, Ubuntu Server
Canonical Ltd
