Re: [PATCH v2 1/2] test: let qemuhotplugtest report details of init fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Fri, Jan 17, 2020 at 6:32 PM Andrea Bolognani <abologna@xxxxxxxxxx> wrote:
On Thu, 2020-01-16 at 09:28 +0100, Christian Ehrhardt wrote:
> If virHostdevManagerGetDefault in qemuhotplugtest fails it works
> for quite a while to later segfault when accessing
> mgr->activePCIHostdevs.
>
> Report the error details and break on a failed init to see the
> real issue right away.
>
> Reviewed-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx>
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@xxxxxxxxxxxxx>
> ---
>  tests/qemuhotplugtest.c | 5 +++++
>  1 file changed, 5 insertions(+)

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>


Thanks for the reviews Daniel and Andrea, I have pushed this (just this - not the 2/2 which is still up for discussion) to master now.
 
--
Andrea Bolognani / Red Hat / Virtualization



--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux