Re: [libvirt PATCH] src: conditionalize / remove use of sys/ioctl.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 17, 2020 at 12:19:45PM +0000, Daniel P. Berrangé wrote:
> Remove many imports of sys/ioctl.h which are redundant,
> and conditionalize remaining usage that needs to compile
> on Windows platforms.
> 
> The previous change to remove the "nonblocking" gnulib
> module indirectly caused the loss of the "ioctl" gnulib
> module that we did not explicitly list in bootstrap.conf
> despite relying on.
> 
> Rather than re-introduce the "ioctl" module this patch
> makes it redundant.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
> 
> 
>  src/util/virhostcpu.c      | 4 +++-
>  src/util/virhostdev.c      | 1 -
>  src/util/virhostmem.c      | 1 -
>  src/util/virnetdev.c       | 4 +++-
>  src/util/virnetdevbridge.c | 4 +++-
>  src/util/virnetdevip.c     | 4 +++-
>  src/util/virnetdevtap.c    | 4 +++-
>  src/util/virperf.c         | 4 +++-
>  src/util/virvsock.c        | 4 +++-
>  9 files changed, 21 insertions(+), 9 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux