Re: [libvirt PATCH v2 11/13] src: conditionally exclude cfmakeraw/termios.h on WIN32

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 16, 2020 at 03:24:46PM +0000, Daniel P. Berrangé wrote:
> The GNULIB termios module ensures termios.h exists (but
> is none the less empty) when building for Windows. We
> already exclude usage of the functions that would exist
> in a real termios.h, so having an empty termios.h is
> not especially useful.
> 
> It is simpler to just put all use of termios.h related
> functions behind a "#ifndef WIN32" conditional.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  configure.ac           |  1 -
>  src/util/virfdstream.c | 10 ++++++----
>  src/util/virfile.c     |  4 +++-
>  src/util/virutil.c     |  1 -
>  tools/virsh.h          |  1 -
>  tools/vsh.c            | 15 ---------------
>  tools/vsh.h            |  4 +++-
>  7 files changed, 12 insertions(+), 24 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux