Re: [PATCH 2/2] run.in: Include tools directory on $PATH.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 16, 2020 at 05:15:42PM +0000, Richard W.M. Jones wrote:
> You normally want to run the locally compiled copy of virsh.  Trying
> to run the installed version with the locally compiled library is a
> recipe for problems with missing symbols and so on.  By adding tools
> to the path we can ensure that (eg) the libguestfs test suite will use
> compatible copies of the library and virsh.
>
> Signed-off-by: Richard W.M. Jones <rjones@xxxxxxxxxx>

Since this patch doesn't break the original behaviour/use case I don't see a
reason why we couldn't tweak PATH, you can have my:
Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>

...but I'd wait a little before merging this patch if anyone with more
expertise has further comments.





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux