On Mon, Jan 13, 2020 at 02:06:21PM +0100, Andrea Bolognani wrote:
On Mon, 2020-01-13 at 13:48 +0100, Michal Privoznik wrote:On 1/13/20 9:30 AM, Thomas Huth wrote: > +++ b/src/conf/domain_conf.c > @@ -13428,6 +13428,8 @@ virDomainInputDefParseXML(virDomainXMLOptionPtr xmlopt, > def->type == VIR_DOMAIN_INPUT_TYPE_KBD) && > (ARCH_IS_X86(dom->os.arch) || dom->os.arch == VIR_ARCH_NONE)) { > def->bus = VIR_DOMAIN_INPUT_BUS_PS2; > + } else if (ARCH_IS_S390(dom->os.arch)) { > + def->bus = VIR_DOMAIN_INPUT_BUS_VIRTIO; > } else { > def->bus = VIR_DOMAIN_INPUT_BUS_USB; > } Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> and pushed.I don't believe either this or the other patch posted by Thomas should have been pushed during the freeze period. I won't ask you to revert them, but please refrain from pushing further changes unless 6.0.0 would be utterly broken without them.
The feature freeze is for refraining from pushing features. Even if the bug was present for a long time, there's no need to have yet-another-release when we know it's broken and the fix is simple. Jano
-- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
