On 1/13/20 2:00 PM, Andrea Bolognani wrote:
On Mon, 2020-01-13 at 13:35 +0100, Michal Privoznik wrote:
On 1/13/20 1:16 PM, Andrea Bolognani wrote:
CC'ing Michal who contributed the patches. Can either you or him
please come up with a superior replacement for the above? Thanks!
How about this:
<change>
<summary>
qemu: Allow accessing NVMe disks directly
</summary>
<description>
Before this release there were two ways to configure a NVMe disk for a
domain. The first was using <disk/> with the <source/>
pointing to the <code>/dev/nvmeXXXX</code>. The other was using PCI
assignment via <hostdev/> element. Both have their disadvantages:
the former adds latency of file system and block layers of the host
kernel, the latter prohibits domain migration. In this release the third
way of configuring NVMe disk is added which combines the advantages and
drops disadvantages of the previous two ways. It's accessible via
<disk type='nvme'/>.
</description>
</change>
Looks good. Care to send that as a separate patch, and possibly give
a R-b to this one (with the NVMe hunk dropped, of course)?
Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
Michal
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
