[RFC PATCH 09/16] qemu: checkpoint: Extract calculation of bitmap merging for checkpoint deletion

[Peter Krempa <pkrempa@xxxxxxxxxx>]

This will allow some testing before refactoring.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
 src/qemu/qemu_checkpoint.c | 72 ++++++++++++++++++++++++--------------
 src/qemu/qemu_checkpoint.h |  7 ++++
 2 files changed, 53 insertions(+), 26 deletions(-)

diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
index 1100f6e744..e75cdd0458 100644
--- a/src/qemu/qemu_checkpoint.c
+++ b/src/qemu/qemu_checkpoint.c
@@ -148,6 +148,46 @@ qemuCheckpointFindActiveDiskInParent(virDomainObjPtr vm,
 }


+int
+qemuCheckpointDiscardDiskBitmaps(virStorageSourcePtr src,
+                                 const char *delbitmap,
+                                 const char *parentbitmap,
+                                 bool chkcurrent,
+                                 virJSONValuePtr actions)
+{
+    if (parentbitmap) {
+        g_autoptr(virJSONValue) arr = NULL;
+
+        if (!(arr = virJSONValueNewArray()))
+            return -1;
+
+        if (qemuMonitorTransactionBitmapMergeSourceAddBitmap(arr,
+                                                             src->nodeformat,
+                                                             delbitmap) < 0)
+            return -1;
+
+        if (chkcurrent) {
+            if (qemuMonitorTransactionBitmapEnable(actions,
+                                                   src->nodeformat,
+                                                   parentbitmap) < 0)
+                return -1;
+        }
+
+        if (qemuMonitorTransactionBitmapMerge(actions,
+                                              src->nodeformat,
+                                              parentbitmap, &arr) < 0)
+            return -1;
+    }
+
+    if (qemuMonitorTransactionBitmapRemove(actions,
+                                           src->nodeformat,
+                                           delbitmap) < 0)
+        return -1;
+
+    return 0;
+}
+
+
 static int
 qemuCheckpointDiscardBitmaps(virDomainObjPtr vm,
                              virDomainCheckpointDefPtr chkdef,
@@ -167,6 +207,7 @@ qemuCheckpointDiscardBitmaps(virDomainObjPtr vm,
         virDomainCheckpointDiskDef *chkdisk = &chkdef->disks[i];
         virDomainDiskDefPtr domdisk = virDomainDiskByTarget(vm->def, chkdisk->name);
         virDomainCheckpointDiskDef *parentchkdisk = NULL;
+        const char *parentbitmap = NULL;

         /* domdisk can be missing e.g. when it was unplugged */
         if (!domdisk)
@@ -178,33 +219,12 @@ qemuCheckpointDiscardBitmaps(virDomainObjPtr vm,
         /* If any ancestor checkpoint has a bitmap for the same
          * disk, then this bitmap must be merged to the
          * ancestor. */
-        if ((parentchkdisk = qemuCheckpointFindActiveDiskInParent(vm, parent, chkdisk->name))) {
-            g_autoptr(virJSONValue) arr = NULL;
-
-            if (!(arr = virJSONValueNewArray()))
-                return -1;
-
-            if (qemuMonitorTransactionBitmapMergeSourceAddBitmap(arr,
-                                                                 domdisk->src->nodeformat,
-                                                                 chkdisk->bitmap) < 0)
-                return -1;
-
-            if (chkcurrent) {
-                if (qemuMonitorTransactionBitmapEnable(actions,
-                                                       domdisk->src->nodeformat,
-                                                       parentchkdisk->bitmap) < 0)
-                    return -1;
-            }
-
-            if (qemuMonitorTransactionBitmapMerge(actions,
-                                                  domdisk->src->nodeformat,
-                                                  parentchkdisk->bitmap, &arr) < 0)
-                return -1;
-        }
+        if ((parentchkdisk = qemuCheckpointFindActiveDiskInParent(vm, parent,
+                                                                  chkdisk->name)))
+            parentbitmap = parentchkdisk->name;

-        if (qemuMonitorTransactionBitmapRemove(actions,
-                                               domdisk->src->nodeformat,
-                                               chkdisk->bitmap) < 0)
+        if (qemuCheckpointDiscardDiskBitmaps(domdisk->src, chkdisk->bitmap,
+                                             parentbitmap, chkcurrent, actions) < 0)
             return -1;
     }

diff --git a/src/qemu/qemu_checkpoint.h b/src/qemu/qemu_checkpoint.h
index eb85611ea6..85fd453d50 100644
--- a/src/qemu/qemu_checkpoint.h
+++ b/src/qemu/qemu_checkpoint.h
@@ -71,3 +71,10 @@ qemuCheckpointCreateFinalize(virQEMUDriverPtr driver,
 void
 qemuCheckpointRollbackMetadata(virDomainObjPtr vm,
                                virDomainMomentObjPtr chk);
+
+int
+qemuCheckpointDiscardDiskBitmaps(virStorageSourcePtr src,
+                                 const char *delbitmap,
+                                 const char *parentbitmap,
+                                 bool chkcurrent,
+                                 virJSONValuePtr actions);
-- 
2.24.1

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list