On Tue, Jan 07, 2020 at 02:43:25PM +0100, Michal Privoznik wrote: > While we discourage people to use the old style of specifying > UEFI for their domains (the old style is putting path to the FW > image under /domain/os/loader/ whilst the new one is using > /domain/os/@firmware), some applications might have not adopted s/adopted/adapted/ > yet. They still rely on libvirt autofilling NVRAM path and > figuring out NVRAM template when using the old way (notably > virt-install does this). And in a way they are right. However, Not "in a way" - they are absolutely always right, because thats what our API guarantee means for apps. So s/And in a way they are right/We must preserve backcompat for this previously supported config approach/ > since we really want distro maintainers to leave > --with-loader-nvram configure option and rely on JSON > descriptors, we need to implement autofilling of NVRAM template > for the old way too. > > Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1782778 > RHEL: https://bugzilla.redhat.com/show_bug.cgi?id=1776949 > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/qemu/qemu_firmware.c | 47 +++++++++++++++++++++++++++++++++++----- > 1 file changed, 42 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
