Re: [PATCH v2 04/12] Remove redundant parameter to virBhyveProcessStart()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 02, 2020 at 05:46:27PM +0000, Ryan Moeller wrote:
> Signed-off-by: Ryan Moeller <ryan@xxxxxxxxxxxxx>
> ---
>  src/bhyve/bhyve_driver.c  |  6 +++---
>  src/bhyve/bhyve_process.c | 16 +++++++---------
>  src/bhyve/bhyve_process.h |  1 -
>  3 files changed, 10 insertions(+), 13 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>

> @@ -140,19 +138,19 @@ virBhyveProcessStart(virConnectPtr conn,
>          goto cleanup;
>      }
>  
> -    VIR_FREE(privconn->pidfile);
> -    if (!(privconn->pidfile = virPidFileBuildPath(BHYVE_STATE_DIR,
> +    VIR_FREE(driver->pidfile);
> +    if (!(driver->pidfile = virPidFileBuildPath(BHYVE_STATE_DIR,
>                                                    vm->def->name))) {

Indent is off here.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux