On Thu, Jan 02, 2020 at 12:07:06PM -0300, Julio Faracco wrote: > The command `domifaddr` can use three different sources to grab IP > address of a Virtual Machine: lease, agent and arp. This parameter does > not have a completer function to return source options. > > Signed-off-by: Julio Faracco <jcfaracco@xxxxxxxxx> > --- ... > + > +char ** > +virshDomainIfAddrSourceCompleter(vshControl *ctl, I'd stay consistent with the existing naming scheme we have in place and expand 'If' to 'Interface' --> virshDomainInterfaceAddrSourceCompleter. Changed and pushed. Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx> -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
