Re: [go-xml PATCH 1/2] Fix virtio-s390 address lookup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 20, 2019 at 05:22:25PM -0500, Cole Robinson wrote:
> It was comparing against spapr-vio
> 
> Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx>
> ---
> All this virtio-s390 stuff is kinda bogus though, because it is
> never actually output in libvirt XML.

Hmm, I wonder what I was thinking when i added that. I guess we can
just delete it all.

> 
>  domain.go | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/domain.go b/domain.go
> index 8c4d7a4..7552c4b 100644
> --- a/domain.go
> +++ b/domain.go
> @@ -5145,7 +5145,7 @@ func (a *DomainAddress) UnmarshalXML(d *xml.Decoder, start xml.StartElement) err
>  	} else if typ == "ccid" {
>  		a.CCID = &DomainAddressCCID{}
>  		return d.DecodeElement(a.CCID, &start)
> -	} else if typ == "spapr-vio" {
> +	} else if typ == "virtio-s390" {
>  		a.VirtioS390 = &DomainAddressVirtioS390{}
>  		return d.DecodeElement(a.VirtioS390, &start)
>  	}
> -- 
> 2.23.0
> 
> --
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux