I've got a report of pull-mode backup not working properly. While investigating I've found out few other problems and one regression caused by a recent patch. All of those are fixed below. Additionally the last 3 patches are RFC and were created based on the discussion on qemu-block and I don't really intend to push them right away. At least until the discussion there is over: https://lists.gnu.org/archive/html/qemu-block/2019-12/msg00416.html Peter Krempa (11): qemu: block: Use proper asyncJob when waiting for completion of blockdev-create qemu: Reset the node-name allocator in qemuDomainObjPrivateDataClear qemu: backup: Configure backup store image with backing file qemu: backup: Move deletion of backup images to job termination qemu: blockjob: Remove infrastructure for remembering to delete image qemu: backup: Properly propagate async job type when cancelling the job qemu: process: Terminate backup job on VM destroy schemas: backup: Remove pointless <choice> for 'name' of backup disk RFC: conf: backup: Allow configuration of names exported via NBD qemu: backup: Implement support for backup disk export name configuration qemu: backup: Implement support for backup disk bitmap name configuration docs/formatbackup.html.in | 9 +++ docs/schemas/domainbackup.rng | 16 ++-- src/conf/backup_conf.c | 11 +++ src/conf/backup_conf.h | 2 + src/qemu/qemu_backup.c | 77 +++++++++++++------ src/qemu/qemu_backup.h | 10 ++- src/qemu/qemu_block.c | 4 +- src/qemu/qemu_blockjob.c | 20 +---- src/qemu/qemu_blockjob.h | 2 - src/qemu/qemu_domain.c | 10 +-- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_process.c | 8 +- .../backup-pull-seclabel.xml | 2 +- .../backup-pull-seclabel.xml | 2 +- .../qemustatusxml2xmldata/backup-pull-in.xml | 1 - 15 files changed, 110 insertions(+), 66 deletions(-) -- 2.23.0 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list