Re: [PATCH] schemas: Allow additional qemu cmd line arguments/env variables and qemuCaps to be interleaved

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 20, 2019 at 10:29 AM Michal Privoznik <mprivozn@xxxxxxxxxx> wrote:
>
> While command line arguments are sort of positional (becasue you

becasue -> because

> have to have two entries, one for "-arg" the other for "value"),
> it doesn't really matter whether env variables come before or
> after command line arguments.
>
> And it matter even less when playing with qemu capabilities.

matter -> matters

>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Patch makes sense and doesn't break backward compat.
I'd take this review with a grain of salt ...

Reviewed-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux