virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx> --- src/logging/log_daemon_config.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/logging/log_daemon_config.c b/src/logging/log_daemon_config.c index ab42921140..97f2de90a6 100644 --- a/src/logging/log_daemon_config.c +++ b/src/logging/log_daemon_config.c @@ -44,16 +44,12 @@ virLogDaemonConfigFilePath(bool privileged, char **configfile) } else { g_autofree char *configdir = NULL; - if (!(configdir = virGetUserConfigDirectory())) - goto error; + configdir = virGetUserConfigDirectory(); *configfile = g_strdup_printf("%s/virtlogd.conf", configdir); } return 0; - - error: - return -1; } -- 2.24.1 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list