On 12/18/19 11:26 AM, Fabiano Fidêncio wrote: > By rewriting virGetUser*Directory() functions using g_get_*_dir() > functions allows us to drop all the different implementations we > keep, as GLib already takes care of those for us. > > Changes since v3: > https://www.redhat.com/archives/libvir-list/2019-December/msg01123.html > - Used g_build_filename() instead of g_strdup_printf(); > > Changes since v2: > https://www.redhat.com/archives/libvir-list/2019-December/msg01064.html > - Addressed comments made by Cole about: > - virGetUserDirectory() should return $HOME; > - virGetUser*Directory() don't append "libvirt" to the returned path > on Windows; > > Changes since v1: > https://www.redhat.com/archives/libvir-list/2019-December/msg01055.html > - Don't check for the return of g_get_*_dir(), as it cannot be NULL; > > Fabiano Fidêncio (4): > util: Rewrite virGetUserDirectory() using g_get_home_dir() > util: Rewrite virGetUserConfigDirectory() using > g_get_user_config_dir() > util: Rewrite virGetUserCacheDirectory() using g_get_user_cache_dir() > util: Rewrite virGetUserRuntimeDirectory() using > g_get_user_runtime_dir() > > src/util/virutil.c | 137 ++++++++++----------------------------------- > 1 file changed, 31 insertions(+), 106 deletions(-) > Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx> - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
