[PATCH v2 0/4] move qemucaps validations from qemu_command to qemu_domain

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Most of the patches were pushed in the first version. These
are the patches that didn't make the cut and needed new
versions.

After these patches I'll refrain from doing more validation
moves to qemu_domain.c. I'll send a RFC discussing how we can
move all the validations to a new file first, then we can
resume this work in the definitive location instead. 


Changes from previous version 1 [1]:
- patch 1 (former patch 04): moved the validation to a new
qemuDomainDeviceDefValidateMemory() function which is called by
qemuDomainDeviceDefValidate().
- patch 2 (former patch 23): added the missing
"if (graphics->data.egl_headless.rendernode)" check.
- patch 3 (former patch 24): virReportEnumRangeError is now being
used in the "default" label error case.
- patch 4 (new): added the VMCOREINFO validation case that I
mentioned about in the cover letter of [1] as a difficult
case, but Cole mentioned that it was simpler than that and that I
was probably missing something. Cole was right.

[1] https://www.redhat.com/archives/libvir-list/2019-December/msg00570.html


Daniel Henrique Barboza (4):
  qemu: command: move NVDIMM validation to qemu_domain.c
  qemu: command: move qemuBuildGraphicsEGLHeadlessCommandLine validation
    to qemu_domain.c
  qemu: move qemuBuildSmartcardCommandLine validation to qemu_domain.c
  qemu: command: move validation of vmcoreinfo to qemu_domain.c

 src/qemu/qemu_command.c | 51 ++----------------------------
 src/qemu/qemu_domain.c  | 70 +++++++++++++++++++++++++++++++++++++++--
 tests/qemuxml2xmltest.c | 30 +++++++++---------
 3 files changed, 87 insertions(+), 64 deletions(-)

-- 
2.23.0


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux