On 12/2/19 9:26 AM, Michal Privoznik wrote: > If a domain has an NVMe disk configured, then we need to allow it > on devices CGroup so that qemu can access it. There is one caveat > though - if an NVMe disk is read only we need CGroup to allow > write too. This is because when opening the device, qemu does > couple of ioctl()-s which are considered as write. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/qemu/qemu_cgroup.c | 97 ++++++++++++++++++++++++++++++------------ > 1 file changed, 69 insertions(+), 28 deletions(-) A lot going on here, a bit tough to digest, the extra helpers I suggested should help here. But I didn't notice anything bad Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx> - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
