Re: [PATCH v3 11/30] conf: Format and parse NVMe type disk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/10/19 12:43 AM, Cole Robinson wrote:
On 12/2/19 9:26 AM, Michal Privoznik wrote:
To simplify implementation, some restrictions are added. For
instance, an NVMe disk can't go to any bus but virtio and has to
be type of 'disk' and can't have startupPolicy set.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx>

Arguably the nvme->namespace == 0 should be in a Validate callback, but
it's extremely minor

Fixed. Initially, I thought that namespace == 0 is invalid XML but I can argue both ways. And since you have inclination to the Validate callback I've moved the check there.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux