On 10/12/2019 12.06, Markus Armbruster wrote: > Thomas Huth <thuth@xxxxxxxxxx> writes: > >> It's been deprecated since QEMU v3.1, so it's time to finally >> remove it. The "id" parameter can simply be used instead. >> >> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx> > [...] >> diff --git a/qapi/net.json b/qapi/net.json >> index 335295be50..ff280ccd16 100644 >> --- a/qapi/net.json >> +++ b/qapi/net.json >> @@ -488,18 +488,16 @@ >> # >> # @id: identifier for monitor commands >> # >> -# @name: identifier for monitor commands, ignored if @id is present >> -# >> # @opts: device type specific properties (legacy) >> # >> # Since: 1.2 >> # >> # 'vlan': dropped in 3.0 >> +# 'name': dropped in 5.0 >> ## > > Uh, when did we start to add "dropped in" to our doc comments? > > We should either do this systematically, or not at all. If the former, > we have quite a few "dropped in" to add belatedly. IIRC this has been suggested by Eric, see e.g.: https://patchwork.kernel.org/patch/10227335/#21501161 Anyway, it should not matter much for this patch here, since the line gets removed again in the 2nd patch anyway. Thomas -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
