On Mon, Dec 09, 2019 at 07:26:13PM -0500, Cole Robinson wrote:
> On 12/9/19 9:08 AM, Daniel P. Berrangé wrote:
> > On Mon, Dec 09, 2019 at 09:02:56AM -0500, Cole Robinson wrote:
> >> The .pc files in src/ are intended for use with the ./run script,
> >> to ease building bindings against an uninstalled libvirt build.
> >> The pointer to the API XML files is incorrect though, it needs to
> >> point into the build tree.
> >>
> >> This fixes use of the run script for building libvirt-python, ex:
> >>
> >> /path/to/libvirt.git/run ./setup.py build
> >>
> >> Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx>
> >> ---
> >> src/libvirt-lxc.pc.in | 2 +-
> >> src/libvirt-qemu.pc.in | 2 +-
> >> src/libvirt.pc.in | 6 +++---
> >> 3 files changed, 5 insertions(+), 5 deletions(-)
> >
> > Sigh, I must have been blind when doing
> >
> > ommit 54fff1856b9c9854fc3f649a52103e30a116c896
> > Author: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > Date: Mon Dec 2 13:18:01 2019 +0000
> >
> > src: fix pkg-config path for API XML files
> >
> >
> > /me wonders why we have a 'datarootdir' parameter in the .pc
> > files at all ? Wonder if this was a typo and meant to be
> > 'datadir', or were the variable all meant to reference
> > 'datarootdir' instead of 'datadir'
> >
> > eg libvirt_lxc_api=${datarootdir}/docs/libvirt-lxc-api.xml
> >
>
> Sure I can do that. Or push this and send a follow up patch removing the
> unused variables, unless we expect apps could be consuming them in some
> way? Your call
Just push this immediate fix to start with.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
