Re: [PATCH v2 24/25] conf: domaincaps: Add 'backup' feature flag

[Eric Blake <eblake@xxxxxxxxxx>]

On 12/3/19 11:17 AM, Peter Krempa wrote:
> This flag will allow figuring out whether the hypervisor supports the
> incremental backup and checkpoint features.
>
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>   docs/formatdomaincaps.html.in  | 8 ++++++++
>   docs/schemas/domaincaps.rng    | 9 +++++++++
>   src/conf/domain_capabilities.c | 1 +
>   src/conf/domain_capabilities.h | 1 +
>   4 files changed, 19 insertions(+)
>
> diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in
> index 0bafb67705..85226328a8 100644
> --- a/docs/formatdomaincaps.html.in
> +++ b/docs/formatdomaincaps.html.in
> @@ -517,6 +517,7 @@
>       &lt;vmcoreinfo supported='yes'/&gt;
>       &lt;genid supported='yes'/&gt;
>       &lt;backingStoreInput supported='yes'/&gt;
> +    &lt;backup supported='yes'/&gt;
>       &lt;sev&gt;
>         &lt;cbitpos&gt;47&lt;/cbitpos&gt;
>         &lt;reduced-phys-bits&gt;1&lt;/reduced-phys-bits&gt;
> @@ -560,6 +561,13 @@
>       the disk to a running guest, or similar.
>       </p>
>
> +    <h4><a id="featureBackup">backup</a></h4>
> +
> +    <p>Reports whether the hypervisor supports the backup,checkpoint and related

space after comma.

Reviewed-by: Eric Blake <eblake@xxxxxxxxxx>

Hmm - as of this series, the test driver supports checkpoints but not 
(yet) backups.  Are there plans to get rudimentary backup support into 
the test driver as well, so that we can declare the feature there as 
well as in qemu?

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list