On Fri, 2009-12-18 at 00:41 +0100, Matthias Bolte wrote: > You're using the old tags (VIR_MEMSTAT_*) and names (free_memory, > total_memory) here. Argh. I forgot to commit my local changes to the python patch :( This is done and will appear in the next series. > You could convert the adjacent if blocks into and if/else if block or > a switch block. Sure. I will play around with it and see if I can spruce the look of this code up a bit. > You're also silently ignoring unknown tags here, but that should be > handled at the libvirt C API level if it should be handled at all. Ignoring unknown tags allows us to inter-operate with a newer remote libvirt version. So this semantic should be okay. -- Thanks, Adam -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list