[PATCH 0/9] Cleanup virConnectPtr usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I've noticed this problem when reviewing a patch on the list [1].

Long story short, dom->conn is not guaranteed to have all driver
pointers set (consider split daemons). I haven't identified any
other violation than what I'm fixing here. But something might have
slipped through my git grep.

1: https://www.redhat.com/archives/libvir-list/2019-December/msg00120.html

Michal Prívozník (9):
  qemu_driver: Push qemuDomainInterfaceAddresses() a few lines down
  qemu: Don't use dom->conn to lookup virNetwork
  qemuGetDHCPInterfaces: Move some variables inside the loop
  qemuGetDHCPInterfaces: Switch to GLib
  libxl: Don't use dom->conn to lookup virNetwork
  libxlGetDHCPInterfaces: Move some variables inside the loop
  libxlGetDHCPInterfaces: Switch to GLib
  lxc: Cleanup virConnectPtr usage
  get_nonnull_domain: Drop useless comment

 src/libxl/libxl_driver.c            |  71 ++++------
 src/lxc/lxc_driver.c                |  12 +-
 src/lxc/lxc_process.c               |  40 +++---
 src/lxc/lxc_process.h               |   2 +-
 src/qemu/qemu_driver.c              | 193 ++++++++++++----------------
 src/remote/remote_daemon_dispatch.c |   3 -
 6 files changed, 139 insertions(+), 182 deletions(-)

-- 
2.23.0

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux