On Thu, Nov 21, 2019 at 11:00:47 +0100, Pavel Mores wrote: > With all plumbing in place, we can now enable the new functionality. > > Signed-off-by: Pavel Mores <pmores@xxxxxxxxxx> > --- > src/qemu/qemu_driver.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index a3ff4b2177..75458f5c8a 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qemu/qemu_driver.c > @@ -18496,10 +18496,10 @@ qemuDomainBlockCommit(virDomainPtr dom, > bool persistjob = false; > bool blockdev = false; > > - /* XXX Add support for COMMIT_DELETE */ > virCheckFlags(VIR_DOMAIN_BLOCK_COMMIT_SHALLOW | > VIR_DOMAIN_BLOCK_COMMIT_ACTIVE | > VIR_DOMAIN_BLOCK_COMMIT_RELATIVE | > + VIR_DOMAIN_BLOCK_COMMIT_DELETE | > VIR_DOMAIN_BLOCK_COMMIT_BANDWIDTH_BYTES, -1); > > if (!(vm = qemuDomainObjFromDomain(dom))) > @@ -18638,7 +18638,8 @@ qemuDomainBlockCommit(virDomainPtr dom, > goto endjob; You must check that VIR_QEMU_CAPS_BLOCKDEV is enabled for this VM otherwise the flag won't work. If blockdev isn't enabled you still must produce an error message. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list