On Thu, Nov 28, 2019 at 10:42:06AM +0000, Daniel P. Berrangé wrote: > On Thu, Nov 28, 2019 at 11:30:32AM +0100, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > > --- > > domain.go | 23 +++++++++++++++++++++++ > > domain_compat.h | 14 ++++++++++++++ > > domain_wrapper.go | 17 +++++++++++++++++ > > domain_wrapper.h | 6 ++++++ > > 4 files changed, 60 insertions(+) > > > > diff --git a/domain.go b/domain.go > > index 360659d..7901d8d 100644 > > --- a/domain.go > > +++ b/domain.go > > @@ -886,6 +886,14 @@ const ( > > DOMAIN_GUEST_INFO_FILESYSTEM = DomainGuestInfoTypes(C.VIR_DOMAIN_GUEST_INFO_FILESYSTEM) > > ) > > > > +type DomainAgentSetResponseTimeoutValues int > > + > > +const ( > > + VIR_DOMAIN_AGENT_RESPONSE_TIMEOUT_BLOCK = DomainAgentSetResponseTimeoutValues(C.VIR_DOMAIN_AGENT_RESPONSE_TIMEOUT_BLOCK) > > + VIR_DOMAIN_AGENT_RESPONSE_TIMEOUT_DEFAULT = DomainAgentSetResponseTimeoutValues(C.VIR_DOMAIN_AGENT_RESPONSE_TIMEOUT_DEFAULT) > > + VIR_DOMAIN_AGENT_RESPONSE_TIMEOUT_NOWAIT = DomainAgentSetResponseTimeoutValues(C.VIR_DOMAIN_AGENT_RESPONSE_TIMEOUT_NOWAIT) > > +) > > At the Go level the constants shouldn't have any VIR_ prefix, as > they're already within the 'libvirt' package namespace. > > > If you strip those then > > Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Fixed and pushed, thanks. Pavel
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
