Re: [PATCH for 5.10.0] docs: don't run xmllint when generating API HTML files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/27/19 3:06 PM, Daniel P. Berrangé wrote:
After generating the API HTML files we run xmllint in docs/html/*.html
to validate the correctness. Since

   commit 0aa8536f14b08dfb5188d0bb3aba532680500d38
   Author: Daniel P. Berrangé <berrange@xxxxxxxxxx>
   Date:   Wed Nov 20 14:49:26 2019 +0000

     docs: generate API reference pages for admin, qemu & lxc libraries

we have many rules generating files into docs/html/. The xmllint
calls for each rule are picking up files which are part-generated by
other parallel build rules resulting in transient errors like:

   GEN      html/index.html
   GEN      html/index-admin.html
   GEN      html/index-qemu.html
   GEN      html/index-lxc.html
   GEN      hvsupport.html.in
html/index-lxc.html:1: parser error : Document is empty

^
make[4]: *** [Makefile:2407: html/index-qemu.html] Error 1

The easiest solution is to move the xmllint rules to the 'make check'
phase of the build.

Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
---
  docs/Makefile.am | 11 +++++++----
  1 file changed, 7 insertions(+), 4 deletions(-)

Right, I've seen some transient docs/ build problems but haven't gotten any near to debug them.

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux