Re: [PATCH for 5.10.0] news: Update for 5.10.0 release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 27, 2019 at 02:21:14PM +0100, Ján Tomko wrote:
> On Wed, Nov 27, 2019 at 12:38:00PM +0000, Daniel P. Berrangé wrote:
> > On Wed, Nov 27, 2019 at 01:34:12PM +0100, Michal Privoznik wrote:
> > > On 11/27/19 1:19 PM, Peter Krempa wrote:
> > > > On Wed, Nov 27, 2019 at 12:08:01 +0000, Daniel Berrange wrote:
> > > > > On Wed, Nov 27, 2019 at 01:05:04PM +0100, Ján Tomko wrote:
> > > > > > On Wed, Nov 27, 2019 at 11:24:56AM +0100, Michal Privoznik wrote:
> > > > > > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> > > > > > > ---
> > > > > > > docs/news.xml | 124 ++++++++++++++++++++++++++++++++++++++++++++++++++
> > > > > > > 1 file changed, 124 insertions(+)
> > > > > > >
> > > > > > > diff --git a/docs/news.xml b/docs/news.xml
> > > > > > > index 72c0edb317..b6782df136 100644
> > > > > > > --- a/docs/news.xml
> > > > > > > +++ b/docs/news.xml
> > > > > > > @@ -81,8 +81,132 @@
> > > > > > >        </change>
> > > > > > >      </section>
> > > > > > >      <section title="Improvements">
> > > > > >
> > > > > > [...]
> > > > > >
> > > > > > > +      <change>
> > > > > > > +        <summary>
> > > > > > > +          More GLib integration
> > > > > > > +        </summary>
> > > > > > > +        <description>
> > > > > > > +          More patches were merged that replace our internal functions with
> > > > > > > +          GLib ones. Also some effort was invested in replacing gnulib modules
> > > > > > > +          with GLib functions.
> > > > > > > +        </description>
> > > > > > > +      </change>
> > > > > > > +      <change>
> > > > > > > +        <summary>
> > > > > > > +          Rewrite of Perl scripts into Python
> > > > > > > +        </summary>
> > > > > > > +        <description>
> > > > > > > +          Libvirt used Perl scripts to check for coding style, generate some
> > > > > > > +          code and things like that. To bring the number of languages used
> > > > > > > +          down, these scripts were rewritten into Python.
> > > > > > > +        </description>
> > > > > > > +      </change>
> > > > > >
> > > > > > IIUC users are the target audience for the news. So far, these are just
> > > > > > internal refactors that mostly benefit developers.
> > > > >
> > > > > The target is also distro packagers, so they learn of things that
> > > > > might affect packaging design.
> > > >
> > > > Well in this case we didn't really remove anything yet so even distro
> > > > packagers may get saturated by these entries if we do it too
> > > > often without any real change.
> > > >
> > > > https://en.wikipedia.org/wiki/The_Boy_Who_Cried_Wolf
> > > >
> > > 
> > > I view news.xml not only as a way of communicating changes to
> > > users/packagers but also as a way of giving credit to developers of some
> > > important features. If we don't want to advertise these two, that's fine.
> > > But then we should also consider blockdev paragraph - it's a change that's
> > > transparent to users, isn't it? Should they care that we implemented it?
> 
> On its own it should be transparent, but the switch to blockdev did fix
> some actual user-visible bugs that depended on it. Peter should have the
> list.
> 
> > 
> > Even though these changes are "internal" they can still be visible to
> > users by virtue of having a high liklihood of introducing new bugs. I
> > think it is worth highlight these kind of major internal refactorings
> > for this reason.
> 
> Okay, can we put them into a new "Refactors" section instead?

Fine with me.



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux