On Wed, Nov 27, 2019 at 01:52:23PM +0100, Peter Krempa wrote:
This reverts commit 421c9550f5446729b513ee50f5c44e6f6969b5a2.
Feel free to demote this from a sentence by removing the trailing period, to make it easier to select.
qemuDomainBlockPullCommon calls virDomainObjEndAPI internally so the original commit made us shed two references of @vm instead of one getting us into a premature free of @vm. This is not a straight revert as qemuDomainBlockPull was modified meanwhile. I've also added a warning comment that @vm is consumed. https://bugzilla.redhat.com/show_bug.cgi?id=1777230 Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> --- /me hides in shame src/qemu/qemu_driver.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-)
Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
