On 11/26/19 10:17 AM, Peter Krempa wrote: > Otherwise it would get dropped later on as untracked despite us knowing > about it. Additionally since we cancelled it we must wait to dismiss it > which would not be possible if we unregister it. This also opened a > window for a race condition since the job state change event of the > just-cancelled job might be delivered prior to us unregistering the job > in which case everything would work properly. > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > --- > src/qemu/qemu_blockjob.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c > index b83d681f06..4d14c3d27c 100644 > --- a/src/qemu/qemu_blockjob.c > +++ b/src/qemu/qemu_blockjob.c > @@ -465,6 +465,8 @@ qemuBlockJobRefreshJobs(virQEMUDriverPtr driver, > > if (rc < 0) > qemuBlockJobUnregister(job, vm); > + else > + job->reconnected = true; > continue; > } > Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx> - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
