On Thu, Nov 21, 2019 at 06:32:11PM +0000, Daniel P. Berrangé wrote: > On Mon, Nov 18, 2019 at 06:02:08PM +0100, Peter Krempa wrote: > > Now that all pieces are in place (hopefully) let's enable -blockdev. > > > > We base the capability on presence of the fix for 'auto-read-only' on > > files so that blockdev works properly, mandate that qemu supports > > explicit SCSI id strings to avoid ABI regression and that the fix for > > 'savevm' is present so that internal snapshots work. > > IIUC, once we enable this, we are fully committed to blockdev > hereafter.... I forgot to say Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
