On 11/21/19 10:23 AM, Peter Krempa wrote:
Commit 5751a0b6b1968bb2354b2ac21cc5938b93009590 added a helper function called virDomainCapsFeaturesInitUnsupported which initialized all domain capability features as unsupported. When adding a new feature this would initialize it as unsupported also for hypervisor drivers which the original author possibly didn't intend to modify. To prevent accidental wrong value being reported in such case revert back to initializing individual features in the hypervisor drivers themselves. This is not a straight revert as additonal patches modified how we store the capabilities. Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> --- CCing all people in the original conversation: CC: Cole Robinson <crobinso@xxxxxxxxxx> CC: Ján Tomko <jtomko@xxxxxxxxxx> CC: Michal Prívozník <mprivozn@xxxxxxxxxx> src/bhyve/bhyve_capabilities.c | 4 +++- src/conf/domain_capabilities.c | 15 --------------- src/conf/domain_capabilities.h | 2 -- src/libvirt_private.syms | 1 - src/libxl/libxl_capabilities.c | 5 +++-- src/qemu/qemu_capabilities.c | 3 ++- 6 files changed, 8 insertions(+), 22 deletions(-)
I like this better. Sorry for not catching this sooner. You can count on my Reviewed-by, but I will let others to express their opinion, Cole?
Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
