On Thu, Dec 17, 2009 at 10:31:47AM +0000, Daniel P. Berrange wrote:
> On Thu, Dec 17, 2009 at 11:05:28AM +0100, Daniel Veillard wrote:
> > On Thu, Dec 17, 2009 at 12:39:35AM +0100, Matthias Bolte wrote:
> > > 2009/12/11 Adam Litke <agl@xxxxxxxxxx>:
> > > >
> > > > /* Domain migration flags. */
> > > > typedef enum {
> > > > @@ -633,6 +682,9 @@ int virDomainInterfaceStats (virDomainPtr dom,
> > > > const char *path,
> > > > virDomainInterfaceStatsPtr stats,
> > > > size_t size);
> > > > +int virDomainMemoryStats (virDomainPtr dom,
> > > > + virDomainMemoryStatPtr stats,
> > > > + unsigned int nr_stats);
> > >
> > > Maybe an 'unsigned int flags' parameter should be added, even if its
> > > unused now it may come in handy for future extensions.
> >
> > Ah, good point !!!
> > Adam, you don't need to propagate it yet though the drivers, but at the
> > public interface in libvirt.h and libvirt.c, let's add it !
>
> Yes it does need to be propagated to the drivers, because the flags
> field has to be added on the wire RPC protocol if we are ever to use
> it in the future.
I guess I didn't got anough sleep !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list