On Thu, Dec 17, 2009 at 11:14:24AM +0100, Jiri Denemark wrote: > > > Changes in version 3: > > > - fix build and segfault on i386 > > > > > > Changes in version 2: > > > - virConnectGetHostCPU() API call was completely removed > > > - 'CPU driver implementation' (11/14) patch was dropped > > > - virConnectCompareCPU() API call is implemented directly by hypervisor > > > drivers > > > - new cpuCompareXML() internal function to make virConnectCompareCPU() > > > simpler > > > > > > Jirka > > > > > > > You've put some relevant documentation about the CPU flag handling to > > the commit messages. IMHO this documentation should be collected and > > the libvirt user relevant part (for example from patch 1 v3) should go > > to the libvirt website sections about the domain/capabilities XML > > format > > Right, good idea. > > > and the libvirt library/driver developer related part (for > > example from patch 9 v3) should go to src/cpu/README, or something > > like that. > > This is also a good idea but I'm not sure where to put the documentation. Is > the src/cpu/README a good place or is there any better place for documenting > internals of libvirt for driver developers? Perhaps HACKING? Although it seems > to document a bit more general techniques used in libvirt. Actually anything that's intended for driver developers can also go on the website in this section: http://libvirt.org/internals.html We should move other stuff we've written like my THREADS.txt guides to there too some time Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list