Re: [PATCH v5 08/23] src: rewrite systemtap probe generator in Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 11, 2019 at 02:38:11PM +0000, Daniel P. Berrangé wrote:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the dtrace2systemtap.pl tool in Python.

This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall structure
of the file and approach is the same.

Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
---
Makefile.am                 |   1 +
scripts/dtrace2systemtap.py | 143 ++++++++++++++++++++++++++++++++++++
src/Makefile.am             |  10 +--
src/dtrace2systemtap.pl     | 130 --------------------------------
4 files changed, 147 insertions(+), 137 deletions(-)
create mode 100755 scripts/dtrace2systemtap.py
delete mode 100755 src/dtrace2systemtap.pl

diff --git a/src/Makefile.am b/src/Makefile.am
index 929eef784c..085c193013 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -530,7 +530,6 @@ if WITH_DTRACE_PROBES
libvirt_la_BUILT_LIBADD += libvirt_probes.lo
libvirt_la_DEPENDENCIES += libvirt_probes.lo libvirt_probes.o
nodist_libvirt_la_SOURCES = libvirt_probes.h
-DTRACE2SYSTEMTAP_FLAGS = --with-modules

Dropping the (now implied) --with-modules flag deserves a mention in the
commit message.


BUILT_SOURCES += libvirt_probes.h libvirt_probes.stp libvirt_functions.stp


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux