On Mon, Nov 18, 2019 at 05:12:23PM +0100, Bjoern Walk wrote:
Hey all, commit 4ac47730: Use g_mkstemp_full instead of mkostemp(s) broke `virsh
Oops,
edit` (at least on S390): virsh # edit test error: write: /tmp/virshQ7SXB0.xml: failed to write to temporary file: Bad file descriptorx I didn't find out why, everything looks normal: # ls -l /proc/$(pgrep virsh)/fd/ total 0 [...] lr-x------. 1 root root 64 Nov 18 16:58 10 -> /tmp/virshAEKYB0.xml # ls -l /tmp/virshAEKYB0.xml -rw-------. 1 root root 0 Nov 18 16:59 /tmp/virshAEKYB0.xml
strace shows that the file is open with O_RDONLY openat(AT_FDCWD, "/tmp/virshXNQGB0.xml", O_RDONLY|O_CREAT|O_EXCL|O_CLOEXEC, 0600) = 9 write(9, "<domain type='kvm'>\n <name>r8</"..., 6087) = -1 EBADF (Bad file descriptor) It seems O_RDWR is only implied by g_mkstemp, not g_mkstemp_full. Jano
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
